Make sure that moderators can interact with trashcans and restrict paginator usage#1358
Merged
Conversation
The `allow_moderation_roles` bool can be specified to allow anyone with a role in `MODERATION_ROLES` to delete
the message.
Akarys42
added
t: feature
Akarys42
force-pushed
the
trashcan-mods
branch
from
c25929c to
eb78b9c
Compare
MarkKoz
reviewed
Jan 19, 2021
MarkKoz
requested changes
Jan 22, 2021
| or user_.id == restrict_to_user.id | ||
| user_.id == restrict_to_user.id | ||
| # The reaction was by a moderator | ||
| or any(role.id in MODERATION_ROLES for role in user_.roles) |
Contributor
There was a problem hiding this comment.
I don't believe the paginator is inherently restricted to guilds. Therefore, this event may get a User which doesn't have roles.
MarkKoz
approved these changes
Jan 24, 2021
HassanAbouelela
approved these changes
Jan 29, 2021
HassanAbouelela
approved these changes
Jan 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait_for_deletion5e93396ctx.authorby default and add an override for mods c25929c